Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix property type of mountTargets in NetApp #8804

Merged
merged 3 commits into from
Mar 26, 2020
Merged

Fix property type of mountTargets in NetApp #8804

merged 3 commits into from
Mar 26, 2020

Conversation

neil-yechenwei
Copy link

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ChenTanyi ChenTanyi added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Mar 23, 2020
@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Mar 23, 2020 •
edited
Loading

azure-sdk-for-java - Release

️✔️ succeeded [Logs] [Expand Details]

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Mar 23, 2020 •
edited
Loading

azure-sdk-for-go - Release

⚠️ warning [Logs] [Expand Details]
  • ⚠️ Generate from 6904417 with merge commit 60c73eb. SDK Automation 13.0.17.20200326.3
  • ⚠️netapp/mgmt/2019-05-01 [Logs]  
      No file is changed.
    • ⚠️netapp/mgmt/2019-06-01 [Logs]  
        No file is changed.
      • ⚠️netapp/mgmt/2019-07-01 [Logs]  
          No file is changed.
        • ⚠️netapp/mgmt/2019-08-01 [Logs]  
            No file is changed.
          • ⚠️netapp/mgmt/2019-10-01 [Logs]  
              No file is changed.
            • ️✔️netapp/mgmt/2019-11-01 [Logs]  [Release SDK Changes]
            • ⚠️preview/netapp/mgmt/2017-08-15 [Logs]  
                No file is changed.

              @openapi-sdkautomation
              Copy link

              openapi-sdkautomation bot commented Mar 23, 2020 •
              edited
              Loading

              azure-cli-extensions - Release

              No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

              @openapi-sdkautomation
              Copy link

              openapi-sdkautomation bot commented Mar 23, 2020 •
              edited
              Loading

              azure-sdk-for-js - Release

              ️✔️ succeeded [Logs] [Expand Details]
              • ️✔️ Generate from 6904417 with merge commit 60c73eb. SDK Automation 13.0.17.20200326.3
              • ️✔️@azure/arm-netapp [Logs]  [Release SDK Changes] 
                [npmPack] npm WARN lifecycle @azure/arm-netapp@7.0.0~prepack: cannot run in wd @azure/arm-netapp@7.0.0 npm install && npm run build (wd=/z/work/azure-sdk-for-js/sdk/netapp/arm-netapp)

              @openapi-sdkautomation
              Copy link

              openapi-sdkautomation bot commented Mar 23, 2020 •
              edited
              Loading

              azure-sdk-for-net - Release

              ❌ failed [Logs] [Expand Details]
              • ❌ Generate from 6904417 with merge commit 60c73eb. SDK Automation 13.0.17.20200326.3
              • ❌Microsoft.Azure.Management.NetApp [Logs]  [Release SDK Changes] 
                  Failed to create the package Microsoft.Azure.Management.NetApp.
Error: dotnet msbuild build.proj /t:CreateNugetPackage /p:Scope=netapp /v:n /p:SkipTests=true , {}

                @openapi-sdkautomation
                Copy link

                openapi-sdkautomation bot commented Mar 23, 2020 •
                edited
                Loading

                azure-sdk-for-python - Release

                - Breaking Change detected in SDK

                ⚠️ warning [Logs] [Expand Details]
                • ⚠️ Generate from 6904417 with merge commit 60c73eb. SDK Automation 13.0.17.20200326.3
                • ⚠️azure-mgmt-netapp [Logs]  [Release SDK Changes] Breaking Change Detected
                  [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[breaking_change_setup] Ignoring mock: markers 'python_version <= "2.7"' don't match your environment
[breaking_change_setup] Cannot uninstall requirement azure-nspkg, not installed
[breaking_change_setup] Command '['/usr/local/bin/python', '-m', 'pip', 'uninstall', '-y', 'azure-nspkg']' returned non-zero exit status 1.
[ChangeLog] Size of delta 7.377% size of original (original: 26866 chars, delta: 1982 chars)
[ChangeLog] **Features**
[ChangeLog] 
[ChangeLog]   - Model ActiveDirectory has a new parameter site
[ChangeLog]   - Added operation VolumesOperations.revert
[ChangeLog] 
[ChangeLog] **Breaking changes**
[ChangeLog] 
[ChangeLog]   - Operation SnapshotsOperations.update has a new signature
[ChangeLog]   - Operation SnapshotsOperations.update has a new signature
[ChangeLog]   - Model MountTarget no longer has parameter end_ip
[ChangeLog]   - Model MountTarget no longer has parameter provisioning_state
[ChangeLog]   - Model MountTarget no longer has parameter subnet
[ChangeLog]   - Model MountTarget no longer has parameter gateway
[ChangeLog]   - Model MountTarget no longer has parameter netmask
[ChangeLog]   - Model MountTarget no longer has parameter start_ip
[ChangeLog]   - Model Snapshot no longer has parameter tags
[ChangeLog]   - Operation SnapshotsOperations.create has a new signature
[ChangeLog]   - Removed operation group MountTargetsOperations

                This was referenced Mar 23, 2020
                Closed
                Closed
                Closed
                Closed
                Closed
                Closed
                Closed
                Closed
                Closed
                Closed
                @ChenTanyi
                Copy link
                Contributor

                @neil-yechenwei Is it a hot fix for previous API format error?

                @azure-pipelines
                Copy link

                Azure Pipelines successfully started running 1 pipeline(s).

                @azure-pipelines
                Copy link

                Azure Pipelines successfully started running 1 pipeline(s).

                @audunn
                Copy link
                Member

                audunn commented Mar 24, 2020

                MountTargets is a generic list, an array of objects of type MountTarget (MountTargetPropertiesDefinition) .
                Defined like this
                public List MountTargets { get; set; }

                I had initially thought to represent like this, that I think is more accurate
                "mountTargets": {
                "title": "mountTargets",
                "type": "array",
                "description": "List of mount targets",
                "items": {
                "$ref": "#/definitions/mountTarget"
                }
                }
                }

                This addresses an issue in the GO SDK

                @akning-ms
                Copy link
                Contributor

                Hi @ArcturusZhang , can you help take a look this? this PR is for GO SDK generation related issue:
                #8604

                @akning-ms akning-ms removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Mar 26, 2020
                @akning-ms akning-ms merged commit 60c73eb into Azure:master Mar 26, 2020
                This was referenced Apr 3, 2020
                Closed
                Merged
                @audunn audunn mentioned this pull request Apr 3, 2020
                Merged
                @changlong-liu changlong-liu mentioned this pull request Apr 14, 2020
                Merged
                00Kai0 pushed a commit to 00Kai0/azure-rest-api-specs that referenced this pull request Oct 12, 2020
                @00Kai0
                Fix property type of mountTargets in NetApp (Azure#8804)
                7dc339c 
                * fix property type of mountTargets in NetApp

* Update code

* Update code
                Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
                Reviewers

                @leonardbf leonardbf Awaiting requested review from leonardbf

                Assignees

                @ChenTanyi ChenTanyi

                Labels
                None yet
                Projects
                None yet
                Milestone
                No milestone
                Development

                Successfully merging this pull request may close these issues.
                5 participants
                @neil-yechenwei @azuresdkci @ChenTanyi @audunn @akning-ms